Skip to content

refactor(GradingEditComponentMaxScore): Set max score #1893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hirokiterashima merged 2 commits into from
Aug 20, 2024
Merged

refactor(GradingEditComponentMaxScore): Set max score #1893

hirokiterashima merged 2 commits into from
Aug 20, 2024

Conversation

@hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Aug 15, 2024

Changes

  • Get the Component and set max score directly instead of calling TeacherProjectService.setMaxScoreForComponent()
  • Remove TeacherProjectService.setMaxScoreForComponent()
  • Remove unused function TeacherProjectService.isNodeIdUsed()

Test

  • In CM > grade by step or team, changing the max score for a component works as before
    • should save changes and update total max score for the node

@hirokiterashima
refactor(GradingEditComponentMaxScore): get node and set max score di…
ed85cf9 
…rectly instead of calling function in TeacherProjectService
@hirokiterashima hirokiterashima added this to the Tech Debt 18 -> 17 milestone Aug 15, 2024
@hirokiterashima hirokiterashima self-assigned this Aug 15, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review August 15, 2024 16:09
@hirokiterashima hirokiterashima requested a review from breity August 15, 2024 16:10
breity
breity approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 75b4575 into develop Aug 20, 2024
@hirokiterashima hirokiterashima deleted the refactor-gradingEditComponentMaxScore branch August 20, 2024 01:14
@hirokiterashima hirokiterashima mentioned this pull request Aug 20, 2024
Closed
@geoffreykwan
Copy link
Member

geoffreykwan commented Aug 22, 2024

🎉 This issue has been resolved in version 5.156.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels

Code Quality released

Projects

No open projects
WISE Development 2023-2024
Status: Done

Milestone

Tech Debt 18 -> 17

Development

Successfully merging this pull request may close these issues.

4 participants

@hirokiterashima @geoffreykwan @breity